RFR: 8262093: java/util/concurrent/tck/JSR166TestCase.java failed "assert(false) failed: unexpected node" [v2]

[Tobias Hartmann]

On Mon, 29 Mar 2021 18:53:02 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> LoadStore node misses Value() method which checks for Top inputs. As result dead data IR subgraph was not removed. Control subgraph is not eliminated because of complicated loop. 
>> 
>> The fix is to add missing Value() method.
>> Small refactoring in StoreCMNode::Value() because StoreNode::Value() already has checks for TOP edges.
>> Added check to SCMemProjNode::Value() which led to changes in GraphKit::compress_string() where call to transform() was missing.
>> Dumping additional info for asserts and code style fixes in macro.cpp.
>> 
>> Tested tier1-4 and xcomp.
>
> Vladimir Kozlov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Additional code style fixes

Thanks for updating! Looks good.

-------------

Marked as reviewed by thartmann (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3226