Integrated: 8262093: java/util/concurrent/tck/JSR166TestCase.java failed "assert(false) failed: unexpected node"
Vladimir Kozlov
kvn at openjdk.java.net
Wed Mar 31 01:21:33 UTC 2021
On Sat, 27 Mar 2021 02:49:34 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
> LoadStore node misses Value() method which checks for Top inputs. As result dead data IR subgraph was not removed. Control subgraph is not eliminated because of complicated loop.
>
> The fix is to add missing Value() method.
> Small refactoring in StoreCMNode::Value() because StoreNode::Value() already has checks for TOP edges.
> Added check to SCMemProjNode::Value() which led to changes in GraphKit::compress_string() where call to transform() was missing.
> Dumping additional info for asserts and code style fixes in macro.cpp.
>
> Tested tier1-4 and xcomp.
This pull request has now been integrated.
Changeset: e073486f
Author: Vladimir Kozlov <kvn at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/e073486f
Stats: 61 lines in 4 files changed: 43 ins; 8 del; 10 mod
8262093: java/util/concurrent/tck/JSR166TestCase.java failed "assert(false) failed: unexpected node"
Reviewed-by: thartmann
-------------
PR: https://git.openjdk.java.net/jdk/pull/3226
More information about the hotspot-compiler-dev
mailing list