RFR: 8266401: mark hotspot compiler/intrinsics/sha/cli tests which ignore VM flags

Igor Ignatyev iignatyev at openjdk.java.net
Sat May 1 17:19:49 UTC 2021


On Sat, 1 May 2021 10:48:37 GMT, Jie Fu <jiefu at openjdk.org> wrote:

> Hi all,
> 
> Could you please review this small and trivial patch that adds `@requires vm.flagless` to `compiler/intrinsics/sha/cli ` tests that ignore VM flags?
> 
> This change makes sense since it will fix some test failures when testing with extra VM flags.
> 
> For example, the following three failures will be fixed when testing with UseAVX<2 on Intel CPUs.
> 
> compiler/intrinsics/sha/cli/TestUseSHA256IntrinsicsOptionOnUnsupportedCPU.java
> compiler/intrinsics/sha/cli/TestUseSHAOptionOnUnsupportedCPU.java
> compiler/intrinsics/sha/cli/TestUseSHA512IntrinsicsOptionOnUnsupportedCPU.java
> 
> 
> Thanks.
> Best regards,
> Jie

Right, now I remember them :) they were actually in my first [webrev](http://cr.openjdk.java.net/~iignatyev//8246497/webrev.00/) for this.

I’m not clear on your decision to add the copyright line to `TestUseSHA3IntrinsicsOptionOnUnsupportedCPU.java`, but not other files. 

— Igor

-------------

PR: https://git.openjdk.java.net/jdk/pull/3829


More information about the hotspot-compiler-dev mailing list