RFR: 8266401: mark hotspot compiler/intrinsics/sha/cli tests which ignore VM flags

Igor Ignatyev iignatyev at openjdk.java.net
Sun May 2 04:07:02 UTC 2021


On Sat, 1 May 2021 10:48:37 GMT, Jie Fu <jiefu at openjdk.org> wrote:

> Hi all,
> 
> Could you please review this small and trivial patch that adds `@requires vm.flagless` to `compiler/intrinsics/sha/cli ` tests that ignore VM flags?
> 
> This change makes sense since it will fix some test failures when testing with extra VM flags.
> 
> For example, the following three failures will be fixed when testing with UseAVX<2 on Intel CPUs.
> 
> compiler/intrinsics/sha/cli/TestUseSHA256IntrinsicsOptionOnUnsupportedCPU.java
> compiler/intrinsics/sha/cli/TestUseSHAOptionOnUnsupportedCPU.java
> compiler/intrinsics/sha/cli/TestUseSHA512IntrinsicsOptionOnUnsupportedCPU.java
> 
> 
> Thanks.
> Best regards,
> Jie

IANAL. you should never change other companies' copyright. if you feel that your changes meet your criteria to add your copyright line, you should add it regardless of the existence/absence of Oracle copyright.

in any case, the patch looks good to me.

-- Igor

-------------

Marked as reviewed by iignatyev (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3829


More information about the hotspot-compiler-dev mailing list