RFR: 8265784: [C2] Hoisting of DecodeN leaves MachTemp inputs behind
Goetz Lindenmaier
goetz at openjdk.java.net
Mon May 3 13:26:52 UTC 2021
On Thu, 22 Apr 2021 18:58:28 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:
> PPC64 and s390 have DecodeN implementations which use a MachTemp input. When LCM hoists the DecodeN, the MachTemp nodes reside in the old block, but should get hoisted together with the DecodeN node.
> Same is true for load Base input which exists on s390 for example. Unfortunately, that's just a platform specific MachNode which is not nicely recognizable in LCM.
Hi,
I think temp must go into a block that dominates both, tempb and block.
Do you know block always dominates tempb (after the if?)
Then you could add assert(block->dominates(tempb), "find legal posittion")
Best regards,
Goetz.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3637
More information about the hotspot-compiler-dev
mailing list