RFR: 8254129: IR Test Framework to support regex-based matching on the IR in JTreg compiler tests [v7]
Christian Hagedorn
chagedorn at openjdk.java.net
Mon May 3 18:10:57 UTC 2021
On Fri, 30 Apr 2021 19:12:08 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:
> I've reviewed all the files but `examples` and `tests`, for them I'd actually recommend you to put `examples` into `tests` (possible in a subdir), and just update readme to say that the examples can be found in test directory.
Thanks a lot Igor! I'll consider to move the `examples` as well tomorrow.
> test/lib/jdk/test/lib/hotspot/ir_framework/TestVMException.java line 34:
>
>> 32: TestVMException(String exceptionInfo) {
>> 33: super("There were one or multiple errors. Please check stderr for more information.");
>> 34: this.exceptionInfo = exceptionInfo;
>
> why can't this info be stored as `Throwable::message`?
There were errors in some cases when the message was too long. Thus, I used a separate field for it which I then print to the stderr.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3508
More information about the hotspot-compiler-dev
mailing list