RFR: 8266332: Adler32 intrinsic for x86 64-bit platforms [v2]

Xubo Zhang github.com+58006833+xbzhang99 at openjdk.java.net
Mon May 3 18:41:51 UTC 2021


On Fri, 30 Apr 2021 20:11:44 GMT, Sandhya Viswanathan <sviswanathan at openjdk.org> wrote:

>> Xubo Zhang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   refactor adler32 algorithm to a new file x86/macroAssembler_x86_adler.cpp; added a scratch reg to vpmulld, and some other issues
>
> src/hotspot/cpu/x86/macroAssembler_x86_adler.cpp line 32:
> 
>> 30: #include "macroAssembler_x86.hpp"
>> 31: 
>> 32: 
> 
> The updateBytesAdler32 should be under #ifdef _LP64, #endif.

#ifdef _LP64 ... #endif  added

> src/hotspot/cpu/x86/stubGenerator_x86_64.cpp line 5824:
> 
>> 5822:       __ enter(); // required for proper stackwalking of RuntimeStub frame
>> 5823: 
>> 5824:       __ vmovdqu(yshuf0, ExternalAddress((address) StubRoutines::x86::_adler32_shuf0_table));
> 
> For vmovdqu also it is good to be explicit with scratch register.

added scratch register to vmovdqu

-------------

PR: https://git.openjdk.java.net/jdk/pull/3806


More information about the hotspot-compiler-dev mailing list