RFR: 8241502: C2: Migrate x86_64.ad to MacroAssembler [v8]

[Vladimir Kozlov]

On Thu, 29 Apr 2021 20:39:11 GMT, John Tortugo <github.com+2249648+JohnTortugo at openjdk.org> wrote:

>> I got a lot of failures on Windows only. Almost all test/hotspot/jtreg/serviceability/sa/ tests failed and others.
>> Examples:
>> 
>> serviceability/sa/TestSysProps.java
>> 
>> #  Internal Error (t:\\workspace\\open\\src\\hotspot\\share\\runtime\\stackValue.cpp:139), pid=7572, tid=26052
>> #  assert(oopDesc::is_oop_or_null(val, false)) failed: bad oop found
>> 
>> compiler/c2/Test6800154.java
>> java.lang.InternalError: 9223372036854775807 / -9223372036854775808 failed: 65547 != 0
>> 	at compiler.c2.Test6800154.run(Test6800154.java:111)
>> 	at compiler.c2.Test6800154.main(Test6800154.java:97)
>
> @vnkozlov - thank you so much for running the tests! The cause of the problems you reported were the last changes I made to the div/mod instructions. I fixed the code and ran all tests again on Linux, macOS, and Windows and they are looking good (jdk tier1, 2, 3, and hotspot_all.

@JohnTortugo  did you fix the last issue? Let me know when I should test it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2420