RFR: 8265518: C1: Intrinsic support for Preconditions.checkIndex [v6]

Yi Yang yyang at openjdk.java.net
Sat May 8 05:36:17 UTC 2021


On Fri, 30 Apr 2021 17:30:33 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:

> It was my hope this would eventually happen when we added `Objects.checkIndex` and the underlying intrinsic. Very good!

Hi Paul,

Thank you for noticing this PR.
> It was my hope this would eventually happen when we added `Objects.checkIndex` and the underlying intrinsic.
Yes, this patch adds C1 intrinsic supports for checkIndex, I will replace all variants of checkIndex with Objects.checkIndex in follow-up PRs.

It seems that Object.checkIndex can not meet our needs because it implicitly passes null to Preconditions.checkIndex, but we want to customize exception messages, so we might add extra APIs in Objects while doing the replacement.

> Very good!
Thank you Paul~

Best Regards,
Yang

-------------

PR: https://git.openjdk.java.net/jdk/pull/3615


More information about the hotspot-compiler-dev mailing list