RFR: 8265956: JVM crashes when matching LShiftVB Node [v5]

[Jie Fu]

On Sat, 8 May 2021 08:41:32 GMT, Wang Huang <whuang at openjdk.org> wrote:

>> It is fount that the rule `match(Set dst (LShiftVB src shift))` is missing on many cpus, such like `aarch64` and `x86`. It is this reason that JVM will crash under `JDK-8265956`'s test case. In this commit, I :
>> * show the crash case `TestVectorShuffleIotaShort`
>> * ~~solve the issue on `aarch64` and `x86` by adding the rule.~~  solve the issue by adding `LShiftCntVNode` without adding any rule
>> * test after fixing on tire1~3
>> 
>> Thank you for your review. Any suggestion is welcome. 
>>                          Wang Huang
>
> Wang Huang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   change to static final

test/hotspot/jtreg/compiler/vectorapi/TestVectorShuffleIotaByte.java line 74:

> 72:             bv1.intoArray(ab_64, 0);
> 73:         }
> 74:         Assert.assertEquals(ab_64, expected_64);

How about putting the expected value as the first parameter, which is suggested by [1] ?
 
[1] https://github.com/openjdk/jdk/blob/master/doc/hotspot-unit-tests.md#first-parameter-is-expected-value

-------------

PR: https://git.openjdk.java.net/jdk/pull/3747