RFR: 8265128: [REDO] Optimize Vector API slice and unslice operations [v4]
Sandhya Viswanathan
sviswanathan at openjdk.java.net
Mon May 10 18:31:30 UTC 2021
> All the slice and unslice variants that take more than one argument can benefit from already intrinsic methods on similar lines as slice(origin) and unslice(origin).
>
> Changes include:
> * Rewrite Vector API slice/unslice using already intrinsic methods
> * Fix in library_call.cpp:inline_preconditions_checkIndex() to not modify control if intrinsification fails
> * Vector API conversion tests thresholds adjustment
>
> Base Performance:
> Benchmark (size) Mode Cnt Score Error Units
> TestSlice.vectorSliceOrigin 1024 thrpt 5 11763.372 ± 254.580 ops/ms
> TestSlice.vectorSliceOriginVector 1024 thrpt 5 599.286 ± 326.770 ops/ms
> TestSlice.vectorSliceUnsliceOrigin 1024 thrpt 5 6627.601 ± 22.060 ops/ms
> TestSlice.vectorSliceUnsliceOriginVector 1024 thrpt 5 401.858 ± 220.340 ops/ms
> TestSlice.vectorSliceUnsliceOriginVectorPart 1024 thrpt 5 421.993 ± 231.703 ops/ms
>
> Performance with patch:
> Benchmark (size) Mode Cnt Score Error Units
> TestSlice.vectorSliceOrigin 1024 thrpt 5 11792.091 ± 37.296 ops/ms
> TestSlice.vectorSliceOriginVector 1024 thrpt 5 8388.174 ± 115.886 ops/ms
> TestSlice.vectorSliceUnsliceOrigin 1024 thrpt 5 6662.159 ± 8.203 ops/ms
> TestSlice.vectorSliceUnsliceOriginVector 1024 thrpt 5 5206.300 ± 43.637 ops/ms
> TestSlice.vectorSliceUnsliceOriginVectorPart 1024 thrpt 5 5194.278 ± 13.376 ops/ms
Sandhya Viswanathan has updated the pull request incrementally with one additional commit since the last revision:
library_call.cpp changes not needed after Objects.checkIndex arguments fixed
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/3804/files
- new: https://git.openjdk.java.net/jdk/pull/3804/files/94f184ef..14439667
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3804&range=03
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3804&range=02-03
Stats: 5 lines in 1 file changed: 0 ins; 3 del; 2 mod
Patch: https://git.openjdk.java.net/jdk/pull/3804.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/3804/head:pull/3804
PR: https://git.openjdk.java.net/jdk/pull/3804
More information about the hotspot-compiler-dev
mailing list