RFR: 8264973: AArch64: Optimize vector max/min/add reduction of two integers with NEON pairwise instructions [v2]

[Dong Bo]

On Mon, 10 May 2021 14:29:47 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Dong Bo has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add assembler tests for smaxp/sminp
>
> Looking now. I can't quite understand how to run tests from panama-vector on JDK head. If the JMH test is relevant to JDK, not just panama-vector, why not add it to JDK?

> @theRealAph we are still working out how best to bring the vector performance tests over to the `test/micro` area of mainline. (Some preliminary work is [here](https://github.com/openjdk/panama-vector/pull/77)). The perf tests in the `panama-vector` are under a maven project and it should be possible to build/run that project with a mainline build of the JDK (the tests should be compatible).

Hi, @theRealAph @PaulSandoz. Thanks for the comments.

Because [1] has not been merged into mainline, we cannot build the tests directly with mainline JDK:

[ERROR] panama-vector/test/jdk/jdk/incubator/vector/benchmark/src/main/java/benchmark/utf8/DecodeBench.java:[354,31] cannot find symbol
  symbol:   method intoCharArray(char[],int)
  location: class jdk.incubator.vector.ShortVector


When I tested this, the incompatible `DecodeBench.java` was deleted first since it is all about `ShortVector` and `ByteVector` rather than `Int64Vector`.
Then the perf tests were built/run with mainline builds of JDK:

mvn install
java -jar target/vector-benchmarks.jar benchmark.jdk.incubator.vector.Int64Vector.["M"|"ADD"]+[AXIN]*["Masked"]*Lanes -wi 10 -w 1000ms -f 1 -i 10 -r 1000ms


[1] https://github.com/openjdk/panama-vector/pull/22

-------------

PR: https://git.openjdk.java.net/jdk/pull/3683