RFR: JDK-8266892: avoid maybe-uninitialized gcc warnings on linux s390x

Tue May 11 09:14:55 UTC 2021

On Tue, 11 May 2021 08:56:05 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> In the linux s390x hs code there are a few "maybe-uninitialized" gcc warnings with gcc 8 (those warning class is disabled currently in jdk17 but enabled e.g. in jdk11).  It would be good to fix them anyway which is done by this small change.

Looks fine and trivial. Consider simplifying the comment.

src/hotspot/cpu/s390/assembler_s390.inline.hpp line 1390:

> 1388:       // Having a default clause makes the compiler happy.
> 1389:       ShouldNotReachHere();
> 1390:       *instr = 0L; // This assignment is there to make gcc8 happy.

Maybe just move the comment to the comment block above:

// Having a default clause and definite assignment makes the compiler happy.

-------------

Marked as reviewed by shade (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3970