RFR: 8266798: C1: More types of instruction can also apply LoopInvariantCodeMotion [v2]

Yi Yang yyang at openjdk.java.net
Tue May 11 10:43:56 UTC 2021


On Tue, 11 May 2021 09:45:05 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Yi Yang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   tchar() before id()
>
> src/hotspot/share/c1/c1_ValueMap.cpp line 592:
> 
>> 590:     assert(!subst->has_subst(), "can't have a substitution");
>> 591: 
>> 592:     TRACE_VALUE_NUMBERING(tty->print_cr("substitution for %c%d set to %c%d", instr->type()->tchar(), instr->id(), subst->id(), subst->type()->tchar()));
> 
> Shouldn't the third argument be a char and the fourth an int?

Good catch, fixed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3965


More information about the hotspot-compiler-dev mailing list