RFR: 8261158: JVMState should not be shared between SafePointNodes [v2]

Tobias Hartmann thartmann at openjdk.java.net
Tue May 11 13:21:36 UTC 2021


On Tue, 11 May 2021 12:44:15 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Tobias Hartmann has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Rename needs_clone_jvms -> needs_deep_clone_jvms
>
> src/hotspot/share/opto/callnode.hpp line 355:
> 
>> 353: 
>> 354:   JVMState* jvms() const { return _jvms; }
>> 355:   virtual bool needs_clone_jvms(Compile* C) { return false; }
> 
> Considering `clone_jvms()` always clones associated JVMS now, `needs_clone_jvms()` becomes confusing.
> A variant that explicitly mentions deep copy is reqruired would be a better alternative.

Thanks Vladimir. I've just updated the PR, what do you think?

-------------

PR: https://git.openjdk.java.net/jdk/pull/3951


More information about the hotspot-compiler-dev mailing list