RFR: 8266854: LibraryCallKit::inline_preconditions_checkIndex modifies control flow even if the intrinsic bailed out [v2]

[Sandhya Viswanathan]

On Tue, 11 May 2021 01:06:25 GMT, Sandhya Viswanathan <sviswanathan at openjdk.org> wrote:

>> LibraryCallKit::inline_preconditions_checkIndex can result in the following assert sometimes:
>>    "# assert(ctrl == kit.control()) failed: Control flow was added although the intrinsic bailed out"
>> 
>> Consider the following code snippet:
>>  ...
>>  set_control(_gvn.transform(new IfTrueNode(rc)));
>>  {
>>    PreserveJVMState pjvms(this);
>>    set_control(_gvn.transform(new IfFalseNode(rc)));
>>    uncommon_trap(Deoptimization::Reason_range_check,
>>                  Deoptimization::Action_make_not_entrant);
>>  }
>>  ..
>>  Here the control is being modified by set_control even though a bailout is possible afterwards.
>>  Moving the set_control later in the intrinsic fixes this.
>> 
>>  This is a small fix. Please review.
>> 
>> Best Regards,
>> Sandhya
>
> Sandhya Viswanathan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Implement review comments from Vladimir Kozlov

@vnkozlov @iwanowww I have implemented your review comments. Please let me know if the changes look good now.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3958