RFR: 8252372: Check if cloning is required to move loads out of loops in PhaseIdealLoop::split_if_with_blocks_post() [v2]

Roland Westrelin roland at openjdk.java.net
Mon May 17 08:12:46 UTC 2021


On Tue, 11 May 2021 09:07:53 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

> This is hard to review but looks reasonable to me. Performance and correctness testing also looks good.

Thanks for reviewing it.

> src/hotspot/share/opto/loopopts.cpp line 1137:
> 
>> 1135: //------------------------------place_near_use---------------------------------
>> 1136: // Place some computation next to use but not inside inner loops.
>> 1137: Node* PhaseIdealLoop::place_near_use(Node* useblock, IdealLoopTree* loop) const {
> 
> Maybe the name and comment should be adjusted since we no longer place it next to the use but right outside of the loop.

Right. Updated.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3689


More information about the hotspot-compiler-dev mailing list