RFR: 8265262: CITime - 'other' incorrectly calculated

Nils Eliasson neliasso at openjdk.java.net
Mon May 17 16:55:00 UTC 2021


This CR fixes a few issues with the CITIme output for C2:

1) The other category for _t_optimize is not removing time spent in _t_vector

2) Some of the _t_incrInline sub counters is called from different contexts - calculating 'other' from total time spent in _t_incrInline expects that the counter usage is strictly hierarchical.

3) I've placed the non-hierarchical counters in braces.

4) Code Installation is a part of Code Emission (_t_output). Indentation fixed.

5) Moved "renumber live" after "Vector" so that they appear in order.

6) Added sub counters "shorten branches" and "fill buffer" to "Code Emission" phase, and added an other category. Before more than 50% of time in Code Emission was unaccounted for, now it's less than 25%.

Please review,
Best regards,
Nils Eliasson

-------------

Commit messages:
 - removed whitespace
 - Add timers
 - fix_counters

Changes: https://git.openjdk.java.net/jdk/pull/4065/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4065&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8265262
  Stats: 36 lines in 3 files changed: 24 ins; 3 del; 9 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4065.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4065/head:pull/4065

PR: https://git.openjdk.java.net/jdk/pull/4065


More information about the hotspot-compiler-dev mailing list