RFR: 8265711: C1: Intrinsify Class.getModifier method [v4]

Vladimir Kozlov kvn at openjdk.java.net
Mon May 17 19:30:41 UTC 2021


On Mon, 17 May 2021 02:20:37 GMT, Yi Yang <yyang at openjdk.org> wrote:

>> It's relatively a common case to get modifiers from a constant Class instance, i.e. ThirdPartyClass.class.getModifiers(). Currently, C1 Canonicalizer missed the opportunity of replacing Class.getModifiers intrinsic calls with compile-time constants.
>
> Yi Yang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   caonicalize in interpreter/c1/c2 modes

Just one small comment you can fix before push. Otherwise it is good.

test/hotspot/jtreg/compiler/c1/CanonicalizeGetModifiers.java line 52:

> 50:  * @requires vm.compiler2.enabled
> 51:  * @library /test/lib
> 52:  * @run main/othervm -XX:TieredStopAtLevel=4 -XX:-TieredCompilation

`-XX:TieredStopAtLevel=4` does not work when Tiered is off. You don't need this flag.

-------------

Marked as reviewed by kvn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3616


More information about the hotspot-compiler-dev mailing list