RFR: 8266332: Adler32 intrinsic for x86 64-bit platforms [v10]
Xubo Zhang
github.com+58006833+xbzhang99 at openjdk.java.net
Mon May 17 20:25:59 UTC 2021
On Mon, 17 May 2021 19:21:17 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> Xubo Zhang has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Remove -XX:+UseAdler32Intrinsics, as it will fail on non-supported platforms
>
> src/hotspot/cpu/x86/macroAssembler_x86.hpp line 1322:
>
>> 1320: Assembler::vpmulld(dst, nds, src, vector_len);
>> 1321: }
>> 1322: void vpmulld(XMMRegister dst, XMMRegister nds, AddressLiteral src, int vector_len, Register scratch_reg = rscratch1);
>
> Looks like my comment was lost.
> I see only last version of method is used in stub. Why you need additional 2 wrapper methods?
> Also the code always pass `scratch_reg` - you don't need to set default value.
I think the first two were introduced by other patches
will remove the scratch_reg
-------------
PR: https://git.openjdk.java.net/jdk/pull/3806
More information about the hotspot-compiler-dev
mailing list