RFR: 8260360: IGV: Short name of combined nodes is hidden by background color
Nils Eliasson
neliasso at openjdk.java.net
Tue May 18 12:19:40 UTC 2021
On Tue, 18 May 2021 07:33:01 GMT, Koichi Sakata <ksakata at openjdk.org> wrote:
> This pull request enables the short name of combined nodes readable.
>
> At present those node are painted out with black because their OutputSlot color is null. So this pull request sets the original color to the OutputSlot.
>
> I tested the following scenario manually:
>
> - Open a graph, then enable "Simplify graph" (as described in the bug report). The result is the following images. There are two graphs. One is black and white only graph, the other is colored graph.
>
> <img width="540" alt="スクリーンショット 2021-05-18 16 25 03" src="https://user-images.githubusercontent.com/60008/118609442-b36bf780-b7f5-11eb-86a4-109b4f11b857.png">
> <img width="540" alt="スクリーンショット 2021-05-18 16 25 33" src="https://user-images.githubusercontent.com/60008/118609451-b666e800-b7f5-11eb-85e0-1e3604109a8a.png">
Looks good.
-------------
Marked as reviewed by neliasso (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/4082
More information about the hotspot-compiler-dev
mailing list