RFR: 8265129: Add intrinsic support for JVM.getClassId [v6]

[Tobias Hartmann]

On Mon, 17 May 2021 07:20:18 GMT, Denghui Dong <ddong at openjdk.org> wrote:

>> 8265129: Add intrinsic support for JVM.getClassId
>
> Denghui Dong has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix crash problem

Hi Denghui,

My testing did not find any more issues but this should be reviewed by someone who knows the JFR internals better than me. Just some quick comments:
- Your bug/PR title is misleading. You are not adding an intrinsic for JVM.getClassId but you are updating the existing intrinsic to handle more cases
- You are completely removing the C1 version of the intrinsic, I'm wondering if that is okay, assuming there was a good reason for adding it in the first place.
- You wrote "Therefore, intensifying this method will decrease the overhead for this usage." Is that really measurable?

Best regards,
Tobias

-------------

PR: https://git.openjdk.java.net/jdk/pull/3470