RFR: 8267098: AArch64: C1 StubFrames end confusingly [v2]

Andrew Haley aph at openjdk.java.net
Tue May 18 15:43:40 UTC 2021


On Tue, 18 May 2021 14:36:05 GMT, Alan Hayward <github.com+4146708+a74nh at openjdk.org> wrote:

>> For many of the stub frames, a leave/ret is generated after the stub has
>> already branched or returned. This is confusing. For these cases, replace
>> the superfluous code with a should_not_reach_here
>> 
>> For handle excception, instead of storing return from the exception
>> handler on the stack, it can be moved directly into lr, replacing a store and
>> load with a single move. (If/when PAC support is implemented, then this store
>> would also have to be signed).
>
> Alan Hayward has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Restore save to stack code
>    
>    Change-Id: I20c9d04d372c2da3fceb6921a3696074561666d9
>  - Add return_state_t enum
>    
>    Change-Id: If4472d3230466ac4409e9b63dedfdb54013c6e3d

Marked as reviewed by aph (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/4030


More information about the hotspot-compiler-dev mailing list