RFR: 8266528: Optimize C2 VerifyIterativeGVN execution time [v2]

Vladimir Kozlov kvn at openjdk.java.net
Wed May 19 00:17:39 UTC 2021


On Tue, 18 May 2021 02:21:36 GMT, Hui Shi <hshi at openjdk.org> wrote:

>> src/hotspot/share/opto/node.cpp line 2249:
>> 
>>> 2247:         }
>>> 2248:       }
>>> 2249:       if (cnt == 2) {
>> 
>> I think it should be `cnt > 1`.
>
> previous loop breaks when meet first input which is same with x, so cnt must be 2 if x is duplicated with previous input.

You are right. I missed `break`. Using an other local VectorSet here may not be cheeper. Okay.
Add comment here. Something about that we processed this node already.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4045


More information about the hotspot-compiler-dev mailing list