RFR: 8267239: C1: RangeCheckElimination for % operator if divisor is IntConstant [v2]
Yi Yang
yyang at openjdk.java.net
Wed May 19 02:42:04 UTC 2021
On Tue, 18 May 2021 14:44:46 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:
>> Yi Yang has updated the pull request incrementally with one additional commit since the last revision:
>>
>> more comment for test
>
> src/hotspot/share/c1/c1_RangeCheckElimination.cpp line 246:
>
>> 244: _bound = new Bound();
>> 245: }
>> 246: }else {
>
> Missing whitespace `}else`
> Looks like C2 does not implement this optimization (should be in ModINode::Value). We should add it.
Thanks for confirming the C2 part, I will double-check it and file an issue for that~
> Missing whitespace }else
Fixed.
-------------
PR: https://git.openjdk.java.net/jdk/pull/4083
More information about the hotspot-compiler-dev
mailing list