RFR: 8265262: CITime - 'other' incorrectly calculated [v2]

Nils Eliasson neliasso at openjdk.java.net
Wed May 19 09:11:17 UTC 2021


> This CR fixes a few issues with the CITIme output for C2:
> 
> 1) The other category for _t_optimize is not removing time spent in _t_vector
> 
> 2) Some of the _t_incrInline sub counters is called from different contexts - calculating 'other' from total time spent in _t_incrInline expects that the counter usage is strictly hierarchical.
> 
> 3) I've placed the non-hierarchical counters in braces.
> 
> 4) Code Installation is a part of Code Emission (_t_output). Indentation fixed.
> 
> 5) Moved "renumber live" after "Vector" so that they appear in order.
> 
> 6) Added sub counters "shorten branches" and "fill buffer" to "Code Emission" phase, and added an other category. Before more than 50% of time in Code Emission was unaccounted for, now it's less than 25%.
> 
> Please review,
> Best regards,
> Nils Eliasson

Nils Eliasson has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:

 - Merge branch 'master' into fix_citime
 - removed whitespace
 - Add timers
 - fix_counters

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/4065/files
  - new: https://git.openjdk.java.net/jdk/pull/4065/files/c7ccc63a..50245c2c

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4065&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4065&range=00-01

  Stats: 4519 lines in 213 files changed: 3329 ins; 736 del; 454 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4065.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4065/head:pull/4065

PR: https://git.openjdk.java.net/jdk/pull/4065


More information about the hotspot-compiler-dev mailing list