RFR: 8266746: C1: Replace UnsafeGetRaw with UnsafeGetObject when setting up OSR entry block [v2]
Yi Yang
yyang at openjdk.java.net
Thu May 20 02:44:13 UTC 2021
On Wed, 19 May 2021 08:47:12 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:
>> Yi Yang has updated the pull request incrementally with one additional commit since the last revision:
>>
>> unaliged_move for ppc/s390
>
> src/hotspot/share/c1/c1_Instruction.hpp line 2318:
>
>> 2316:
>> 2317: // accessors
>> 2318: bool is_raw_get() { return _is_raw_get; }
>
> I would rename this to `_is_raw` because we already know it's a get.
Thanks Tobias for the review! All fixed. I will test it on Linux(already tested)/Mac/Windows(aarch64+x86_64) later. But I don't have ppc and s390 machines so I'm not sure how to test it on them...
-------------
PR: https://git.openjdk.java.net/jdk/pull/3917
More information about the hotspot-compiler-dev
mailing list