RFR: 8267332: xor value should handle bounded values [v5]
Claes Redestad
redestad at openjdk.java.net
Fri May 21 09:52:28 UTC 2021
On Fri, 21 May 2021 09:48:35 GMT, Nils Eliasson <neliasso at openjdk.org> wrote:
>> In the discussion of https://github.com/openjdk/jdk/pull/3938 a limitation in C2 was found. C2 fails to eliminate obvious bound checks for indexes that are masked with xor.
>>
>> The Xor for two values that have a lower bound of zero or more, the resulting lower bound is zero.
>> The Xor for two values that have a upperbound above zero, the resulting upper bound is the max of the next_power_of_2-1.
>>
>> Test supplied.
>>
>> Please review,
>> Best regards,
>> Nils Eliasson
>
> Nils Eliasson has updated the pull request incrementally with one additional commit since the last revision:
>
> Removed unnecessary check
Looks good!
-------------
Marked as reviewed by redestad (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/4136
More information about the hotspot-compiler-dev
mailing list