RFR: 8266950: Remove vestigial support for non-strict floating-point execution [v2]

[Jie Fu]

On Fri, 21 May 2021 18:16:23 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

> There are some suspicious failures on linux-x86 in pre-submit testing results:
> 
> * compiler/c1/Test6855215.java
> * compiler/intrinsics/string/TestStringLatin1IndexOfChar.java
> 
> The tests explicitly specify `-XX:UseSSE=0`, so it may be related to the patch. Anybody interested in linux-x86 want to take a look? @shade @DamonFool

compiler/c1/Test6855215.java crashes on x86_32 with the latest patch.

#
# A fatal error has been detected by the Java Runtime Environment:
#
#  Internal Error (/home/jdk/src/hotspot/cpu/x86/c1_LinearScan_x86.cpp:683), pid=13254, tid=13270
#  assert(op2->tmp1_opr()->is_fpu_register()) failed: strict operations need temporary fpu stack slot
#
# JRE version: OpenJDK Runtime Environment (17.0) (fastdebug build 17-internal+0-adhoc..jdk)
# Java VM: OpenJDK Server VM (fastdebug 17-internal+0-adhoc..jdk, mixed mode, sharing, tiered, g1 gc, linux-x86)
# Problematic frame:
# V  [libjvm.so+0x64fcf0]  FpuStackAllocator::handle_op2(LIR_Op2*)+0x120
#

Current CompileTask:
C1:    109   66    b  3       java.util.HashMap::resize (356 bytes)

Stack: [0xa1f7f000,0xa2000000],  sp=0xa1ffe540,  free space=509k
Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code)
V  [libjvm.so+0x64fcf0]  FpuStackAllocator::handle_op2(LIR_Op2*)+0x120
V  [libjvm.so+0x65232c]  FpuStackAllocator::allocate_block(BlockBegin*)+0x28c
V  [libjvm.so+0x6526af]  FpuStackAllocator::allocate()+0xcf
V  [libjvm.so+0x652a4d]  LinearScan::allocate_fpu_stack()+0xcd
V  [libjvm.so+0x648d7a]  LinearScan::do_linear_scan()+0x39a
V  [libjvm.so+0x588f40]  Compilation::emit_lir()+0xd10
V  [libjvm.so+0x58ba60]  Compilation::compile_java_method()+0x720
V  [libjvm.so+0x58c287]  Compilation::compile_method()+0x247
V  [libjvm.so+0x58cbe3]  Compilation::Compilation(AbstractCompiler*, ciEnv*, ciMethod*, int, BufferBlob*, bool, DirectiveSet*)+0x3d3
V  [libjvm.so+0x58de72]  Compiler::compile_method(ciEnv*, ciMethod*, int, bool, DirectiveSet*)+0x1b2
V  [libjvm.so+0x83f5fb]  CompileBroker::invoke_compiler_on_method(CompileTask*)+0xc6b
V  [libjvm.so+0x83ff71]  CompileBroker::compiler_thread_loop()+0x491
V  [libjvm.so+0x86b8c6]  CompilerThread::thread_entry(JavaThread*, JavaThread*)+0x56
V  [libjvm.so+0x14b28e2]  JavaThread::thread_main_inner()+0x242
V  [libjvm.so+0x14b794a]  Thread::call_run()+0xfa
V  [libjvm.so+0x10fc9bf]  thread_native_entry(Thread*)+0x11f
C  [libpthread.so.0+0x63bd]  start_thread+0xfd


compiler/intrinsics/string/TestStringLatin1IndexOfChar.java seems fine on my x86_32.

I didn't take a further look at the crash since it's already weekend now.
Thanks.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3991