RFR: 8264973: AArch64: Optimize vector max/min/add reduction of two integers with NEON pairwise instructions [v2]

Dong Bo dongbo at openjdk.java.net
Mon May 24 12:47:10 UTC 2021


On Mon, 24 May 2021 11:09:44 GMT, Andrew Haley <aph at openjdk.org> wrote:

> > _Mailing list message from [Andrew Haley](mailto:aph at redhat.com) on [hotspot-compiler-dev](mailto:hotspot-compiler-dev at mail.openjdk.java.net):_
> > On 5/10/21 6:55 AM, Dong Bo wrote:
> > > PING? Any comments/suggestions are appreciated.
> > > Although this has been reviewed by Ningsheng, we still need help from reviewers here.
> > 
> > 
> > I'm testing this now.
> 
> I'm back on this, and I can't see how to run the tests. Paul Sandoz says the perf tests in the `panama-vector` are under a maven project, but which maven project is that?
> 
> You say "When I tested this, the incompatible DecodeBench.java was deleted first since it is all about ShortVector and ByteVector rather than Int64Vector." but I don't know what that means.
> 
> Please provide step-by-step instructions that allow anyone to reproduce your results.

Hi, here are the instructions I used to run the benchmarks:
1. Get the benchmark project in `https://github.com/openjdk/panama-vector/tree/vectorIntrinsics/test/jdk/jdk/incubator/vector/benchmark` (I do this via git):

## git clone https://github.com/openjdk/panama-vector.git
## cd panama-vector
## git checkout -b vectorIntrinsics remotes/origin/vectorIntrinsics

2. Delete incompatible `DecodeBench.java` and compile the project with mainline JDK:

## <set JAVA_HOME to the mainline JDK path>
## cd test/jdk/jdk/incubator/vector/benchmark
## rm src/main/java/benchmark/utf8/DecodeBench.java
## mvn install

3. Run tests:
`## <PATH_TO_TEST_JDK>/bin/java -jar target/vector-benchmarks.jar benchmark.jdk.incubator.vector.Int64Vector.["M"|"ADD"]+[AXIN]*["Masked"]*Lanes -wi 10 -w 1000ms -f 1 -i 10 -r 1000ms`

-------------

PR: https://git.openjdk.java.net/jdk/pull/3683


More information about the hotspot-compiler-dev mailing list