RFR: 8266951: Partial in-lining for vectorized mismatch operation using AVX512 masked instructions [v7]

Vladimir Ivanov vlivanov at openjdk.java.net
Mon May 31 08:11:25 UTC 2021


On Mon, 31 May 2021 07:50:10 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8266951: Review comments resolution.
>
> src/hotspot/share/opto/library_call.cpp line 5251:
> 
>> 5249:       Node* cmp_res = _gvn.transform(new BoolNode(length_cmp, BoolTest::le));
>> 5250: 
>> 5251:       fast_path = generate_guard(cmp_res, NULL, PROB_MAX);
> 
> It looks confusing because `LibraryCallKit::generate_guard()` advertises the opposite.  
> 
> // In all cases, GraphKit::control() is updated to the fast path.
> // The returned value represents the control for the slow path.
> 
> Is there a bug there (fast and slow path code swapped)?

Also, what happens when the control implicitly set (fast path) is dead? I'd expect a `stopped()` check, but don't see any.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3999


More information about the hotspot-compiler-dev mailing list