RFR: 8276105: C2: Conv(D|F)2(I|L)Nodes::Ideal should handle rounding correctly [v2]

[Aleksey Shipilev]

On Mon, 1 Nov 2021 14:29:12 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

> Looks good. Is it worth adding the flag combinations to the test?

Honestly, the fact that we fail on that SuperWord packing tier1 test appears to be a pure luck. Also, x86_64 would default to UseSSE >= 2 anyway, so such a config would only make sense for x86_32 running in a quite old mode. So, instead of adding the test configuration to the test, I just added some `-XX:UseSSE=0 -XX:UseAVX=0` runs to our CIs. It is unlikely we would regress this particular place again.

> src/hotspot/share/opto/convertnode.cpp line 148:
> 
>> 146: Node *ConvD2LNode::Ideal(PhaseGVN *phase, bool can_reshape) {
>> 147:   if (in(1)->Opcode() == Op_RoundDouble) {
>> 148:     set_req(1,in(1)->in(1));
> 
> Whitespace after `,` is missing.

Fixed, thanks.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6176