Integrated: JDK-8276175: codestrings.validate_vm gtest still broken on ppc64 after JDK-8276046

Thomas Stuefe stuefe at openjdk.java.net
Tue Nov 2 13:07:15 UTC 2021


On Fri, 29 Oct 2021 14:17:10 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> Frustratingly, JDK-8276046 failed to work because the #ifdef PPC was added to the existing group of #ifdefs at the very start of test_codestrings.cpp.
> 
> PPC is not a primary macro however, it gets set via macros.hpp if one of PPC32 or PPC64 is set. Therefore this only works after the inclusion of macro.hpp (Works for ZERO and PRODUCT, since those are primary macros).
> 
> This fix revives my original fix using the DISABLED_... moniker on test functions. That seems to be the default way to disable tests anyway.

This pull request has now been integrated.

Changeset: b889f2a8
Author:    Thomas Stuefe <stuefe at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/b889f2a88a5e182d2424b741d8fedf2c784442f1
Stats:     8 lines in 1 file changed: 5 ins; 3 del; 0 mod

8276175: codestrings.validate_vm gtest still broken on ppc64 after JDK-8276046

Reviewed-by: mdoerr

-------------

PR: https://git.openjdk.java.net/jdk/pull/6174


More information about the hotspot-compiler-dev mailing list