RFR: 8276227: ciReplay: SIGSEGV if classfile for replay compilation is not present after JDK-8275868 [v2]

[Dean Long]

On Mon, 1 Nov 2021 19:49:22 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Christian Hagedorn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add test
>
> src/hotspot/share/ci/ciReplay.cpp line 890:
> 
>> 888:     // This also ensures that older replay files work.
>> 889:     _protection_domain_initialized = true;
>> 890: 
> 
> I don't see how this helps older replay files.  In fact, it seems like it could make replay for older replay files fail, if the first entry has a different protection domain than the main class.
> 
> If we really want to preserve the old behavior of old replay files, then I think we need to add a version number or some other keyword so that we can tell if a replay file is old or not.  However, in my opinion supporting old replay files should not be a goal.

I'm having second thoughts on not supporting old replay files.  It's easy enough to add a version number, which allows us to introduce incompatible changes without breaking old replay files.  I'll probably introduce a version number with my fix for 8276095.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6189