RFR: 8276227: ciReplay: SIGSEGV if classfile for replay compilation is not present after JDK-8275868 [v2]

Dean Long dlong at openjdk.java.net
Wed Nov 3 19:45:09 UTC 2021


On Wed, 3 Nov 2021 08:09:33 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> I'm having second thoughts on not supporting old replay files.  It's easy enough to add a version number, which allows us to introduce incompatible changes without breaking old replay files.  I'll probably introduce a version number with my fix for 8276095.
>
> You're right. A version number would solve this completely. This implementation is more robust than the previous one but not complete. Here we only try to set the protection domain once where in the previous implementation, we would have picked the first non-null protection domain found (which could happen after looking at many classes). Do you want to revisit this code with the introduction of version numbers in 8276095 and we proceed with this temporary fix?

Yes, go ahead with your fix.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6189


More information about the hotspot-compiler-dev mailing list