RFR: 8276151: AArch64: Incorrect result for double to int vector conversion [v2]
Ningsheng Jian
njian at openjdk.java.net
Fri Nov 5 02:34:09 UTC 2021
On Thu, 4 Nov 2021 16:47:21 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:
>> Ningsheng Jian has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Address review comments from Andrew.
>
> Java changes look good.
>
> What are your thoughts about applying the changes to all `VectorCastShape*Test.java`? Since I presume this could also impact ARM SVE and other architectures.
>
> The duplication could be removed by placing the repeated code in a super class. This could be a follow on update if needed after integration of https://github.com/openjdk/jdk/pull/5873.
Thank you @PaulSandoz for the review!
>
> What are your thoughts about applying the changes to all `VectorCastShape*Test.java`? Since I presume this could also impact ARM SVE and other architectures.
>
> The duplication could be removed by placing the repeated code in a super class. This could be a follow on update if needed after integration of #5873.
Since SVE supports 128bits, so it could also test ARM SVE. I was also thinking about expanding the tests to other bits, but since we have JDK-8259610 recorded, it would be better to eventually fix existing vectorapi vector conversion tests there.
-------------
PR: https://git.openjdk.java.net/jdk/pull/6247
More information about the hotspot-compiler-dev
mailing list