RFR: 8276901: Implement UseHeavyMonitors consistently
Roman Kennke
rkennke at openjdk.java.net
Wed Nov 10 16:55:54 UTC 2021
The flag UseHeavyMonitors seems to imply that it makes Hotspot always use inflated monitors, rather than stack locks. However, it is only implemented in the interpreter that way. When it calls into runtime, it would still happily stack-lock. Even worse, C1 uses another flag UseFastLocking to achieve something similar (with the same caveat that runtime would stack-lock anyway). C2 doesn't have any such mechanism at all.
I would like to experiment with disabling stack-locking, and thus, having this flag work as expected would seem very useful.
The change removes the C1 flag UseFastLocking, and replaces its uses with equivalent (i.e. inverted) UseHeavyMonitors instead. I think it makes sense to make UseHeavyMonitors develop (I wouldn't want anybody to use this in production, not currently without this change, and not with this change). I also added a flag VerifyHeavyMonitors to be able to verify that stack-locking is really disabled. We can't currently verify this uncondiftionally (e.g. in debug builds) because all non-x86_64 platforms would need work.
Testing:
- [x] tier1
- [x] tier2
- [ ] tier3
- [ ] tier4
-------------
Commit messages:
- Change VerifyHeavyMonitors flag to diagnostic
- 8276901: Implement UseHeavyMonitors consistently
Changes: https://git.openjdk.java.net/jdk/pull/6320/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6320&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8276901
Stats: 190 lines in 12 files changed: 54 ins; 18 del; 118 mod
Patch: https://git.openjdk.java.net/jdk/pull/6320.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/6320/head:pull/6320
PR: https://git.openjdk.java.net/jdk/pull/6320
More information about the hotspot-compiler-dev
mailing list