RFR: 8276453: Undefined behavior in C1 LIR_OprDesc causes SEGV in fastdebug build [v6]

[Dean Long]

On Thu, 11 Nov 2021 01:57:58 GMT, Man Cao <manc at openjdk.org> wrote:

>> Hi all,
>> 
>> Could anyone provide some feedback on this bug fix and refactoring change? See https://bugs.openjdk.java.net/browse/JDK-8276453 for more details.
>> If the direction of this change looks good, we can proceed removing the "UGLY HACK" in c1_LIR.hpp and refactor occurrences of "opr->fn()" to "opr.fn()".
>
> Man Cao has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Use nullOpr() or {} instead of LIR_Opr()
>  - Revert the renaming from LIR_OprDesc to LIR_Opr to minimize patch size

src/hotspot/cpu/arm/c1_LIRGenerator_arm.cpp line 367:

> 365: 
> 366: void LIRGenerator::CardTableBarrierSet_post_barrier_helper(LIR_Opr addr, LIR_Const* card_table_base) {
> 367:   assert(addr->is_register(), "must be a register at this point");

The above rename seems unnecessary.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6221