RFR: 8275448: [REDO] AArch64: Implement string_compare intrinsic in SVE [v3]

Tobias Hartmann thartmann at openjdk.java.net
Thu Nov 11 09:23:31 UTC 2021


On Thu, 11 Nov 2021 02:19:41 GMT, TatWai Chong <duke at openjdk.java.net> wrote:

> They are almost identical except the comparison in the stub code has been changed from "if (!UseSVE)" to "if (UseSVE == 0)". It doesn't mean that is the cause of these failures. The generated codes from Toolchains are different from patch to patch. They should be equivalent but as I'm not familiar macOS toolchain, this change can avoid unnecessary casting from `uint` to `bool`. Please see [UseSVE](https://github.com/openjdk/jdk/blob/673ce7efa56e7eb54266af6fe795d46d57f51bdc/src/hotspot/cpu/aarch64/globals_aarch64.hpp#L101)

I undid that change and re-executed testing. No failures. Integrating this again without knowing the root cause of the previous failures is a bit concerning.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6072


More information about the hotspot-compiler-dev mailing list