RFR: 8273563: Improve performance of implicit exceptions with -XX:-OmitStackTraceInFastThrow [v6]

Volker Simonis simonis at openjdk.java.net
Thu Nov 11 09:54:38 UTC 2021


On Wed, 10 Nov 2021 16:57:14 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Volker Simonis has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add new WhiteBox functionality to sun/hotspot/WhiteBox.java as well to avoid warnings in the tests which are still using it.
>
> src/hotspot/share/runtime/deoptimization.cpp line 2695:
> 
>> 2693:   return 0;
>> 2694: }
>> 2695: 
> 
> Why do we need this? Is it a placeholder for a future enhancement? If so, a comment would at least be helpful.

That's a tricky one :)

It's needed to fix the Minimal/Zero builds. It's inside a the `#else` branch of a `#ifdef COMPILER2_OR_JVMCI` condition together with a bunch of other methods which have an empty body in the case we have no C2 or JVMCI.
Could certainly be implemented more elegant but I decided to adhere to the current coding style in `deoptimization.cpp` :)

-------------

PR: https://git.openjdk.java.net/jdk/pull/5488


More information about the hotspot-compiler-dev mailing list