RFR: 8276563: Undefined Behaviour in class Assembler [v2]

Andrew Haley aph at openjdk.java.net
Thu Nov 11 11:56:38 UTC 2021


On Tue, 9 Nov 2021 13:26:26 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Andrew Haley has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Cleanup, constify.
>>  - Cleanup, constify.
>
> src/hotspot/cpu/aarch64/register_aarch64.hpp line 179:
> 
>> 177:   // accessors
>> 178:   bool is_valid() const           { return this < invalid(); }
>> 179:   bool has_byte_register() const  { return is_valid(); }
> 
> Is `has_byte_register` needed here? I see it in the previous code for `Register` but not for `FloatRegister`.
> Suggestion:

Done.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6280


More information about the hotspot-compiler-dev mailing list