RFR: 8277089: Use system binutils to build hsdis [v2]
Yasumasa Suenaga
ysuenaga at openjdk.java.net
Mon Nov 15 13:19:56 UTC 2021
> hsdis requires binutils source tree for building. Most of Linux distros provide binutils package. (e.g. binutils-devel from Fedora, binutils-dev from Ubuntu)
> It would be nice to be able to use them like zlib and lcms.
>
> Unfortunately bfdver.h would not be provided because it is not included install files (`make install`) in binutils. So I changed to use `SEC_ELF_OCTETS` macro to detect binutils version because it was introduced at the same time as `bfd_octets_per_byte()`.
>
> https://sourceware.org/git/?p=binutils-gdb.git;a=commit;f=bfd/bfd-in2.h;h=618265039f697eab9e72bb58b95fc2d32925df58
>
> Please see [JDK-8244819](https://bugs.openjdk.java.net/browse/JDK-8244819) why we need version check.
Yasumasa Suenaga has updated the pull request incrementally with one additional commit since the last revision:
Refactoring
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/6378/files
- new: https://git.openjdk.java.net/jdk/pull/6378/files/fc99dc17..a43ce9aa
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=6378&range=01
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=6378&range=00-01
Stats: 57 lines in 1 file changed: 34 ins; 19 del; 4 mod
Patch: https://git.openjdk.java.net/jdk/pull/6378.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/6378/head:pull/6378
PR: https://git.openjdk.java.net/jdk/pull/6378
More information about the hotspot-compiler-dev
mailing list