RFR: 8275448: [REDO] AArch64: Implement string_compare intrinsic in SVE [v3]

[TatWai Chong]

On Fri, 12 Nov 2021 07:00:05 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>>> Now, only the `gtest/GTestWrapper.java` fails in `AssemblerAArch64::validate_vm`.
>> 
>> That is still quite strange. I just tried `gtest/GTestWrapper.java` on that commit on an M1 Mac and it passed (both fastdebug and release build). Could you post the log of the failing test?
>
>> Could you post the log of the failing test?
> 
> The log file is not too helpful, it just contains:
> 
> 
> java.lang.AssertionError: gtest execution failed; exit code = 2. the failed tests: [AssemblerAArch64::validate_vm, ... AssemblerAArch64::validate_vm, AssemblerAArch64::validate_vm]
> 	at GTestWrapper.main(GTestWrapper.java:98)
> 	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
> 	at java.base/java.lang.reflect.Method.invoke(Method.java:577)
> 	at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:312)
> 	at java.base/java.lang.Thread.run(Thread.java:833)
> 
> 
> Where the `AssemblerAArch64::validate_vm` is repeated many times.
> 
>> @tatwaichong the `gtest/GTestWrapper.java` failure was on a re-test of your original commit, [8b1b6f9](https://github.com/openjdk/jdk/commit/8b1b6f9fb375bbc2de339ad8f526ca4d5f83dc70). This latest PR seems fine.
> 
> Yes, exactly.
> 
> As this change seems stable, I'm fine with integrating it.

@TobiHartmann, @merykitty Hi, could you have a look at the failure of Linux x86 (hs/tier1 compiler) in compiler/c2/irTests/TestUnsignedComparison.java?

It seems that failure isn't introduced by this patch.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6072