RFR: JDK-8277139 Improve code readability in PredecessorValidator (c1_IR.cpp) [v2]

[Ludvig Janiuk]

On Wed, 24 Nov 2021 12:50:38 GMT, Ludvig Janiuk <duke at openjdk.java.net> wrote:

>> Refactor PredecessorValidator, more or less applying the following:
>> 
>> declare variables where used
>> redeclare instead of reuse variables
>> move assert to a more logical place
>> remove unused length variable
>> inline variables where senseful
>> split loops
>> extract methods
>> 
>> this is done in preparation for work on optimizing IR::verify. IR::verify calls PredecessorValidator. If the work of PredecessorValidator is made clearer, it will be easier to reason about where IR::verify doesn't need to be called (or where a subset of it would suffice).
>
> Ludvig Janiuk has updated the pull request incrementally with one additional commit since the last revision:
> 
>   formatting: type asterisks

Okay, all the asterisks should be in their appropriate places now :)

-------------

PR: https://git.openjdk.java.net/jdk/pull/6394