Integrated: JDK-8277139 Improve code readability in PredecessorValidator (c1_IR.cpp)

Ludvig Janiuk duke at openjdk.java.net
Fri Nov 26 09:55:09 UTC 2021


On Mon, 15 Nov 2021 18:26:36 GMT, Ludvig Janiuk <duke at openjdk.java.net> wrote:

> Refactor PredecessorValidator, more or less applying the following:
> 
> declare variables where used
> redeclare instead of reuse variables
> move assert to a more logical place
> remove unused length variable
> inline variables where senseful
> split loops
> extract methods
> 
> this is done in preparation for work on optimizing IR::verify. IR::verify calls PredecessorValidator. If the work of PredecessorValidator is made clearer, it will be easier to reason about where IR::verify doesn't need to be called (or where a subset of it would suffice).

This pull request has now been integrated.

Changeset: 040b2c52
Author:    Ludvig Janiuk <ludvig.j.janiuk at oracle.com>
Committer: Nils Eliasson <neliasso at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/040b2c52d3e82048630fbd45a7db48a5e65204b7
Stats:     75 lines in 1 file changed: 26 ins; 23 del; 26 mod

8277139: Improve code readability in PredecessorValidator (c1_IR.cpp)

Reviewed-by: thartmann, chagedorn

-------------

PR: https://git.openjdk.java.net/jdk/pull/6394


More information about the hotspot-compiler-dev mailing list