Integrated: JDK-8277382 make c1 BlockMerger use IR::verify only when necessary

Ludvig Janiuk duke at openjdk.java.net
Mon Nov 29 06:45:09 UTC 2021


On Thu, 18 Nov 2021 13:30:02 GMT, Ludvig Janiuk <duke at openjdk.java.net> wrote:

> This PR removes two calls to `IR::verify` which were unnecessary. The reason they are unnecessary is that `try_merge` does not always take any action. There is not need to verify if nothing has changed. In the cases that `try_merge` does do anything, it already calls `IR::verify` afterwards.
> 
> This PR also switches some deeply nested if statements in `try_merge` to early returns.

This pull request has now been integrated.

Changeset: c3a7f2f4
Author:    Ludvig Janiuk <ludvig.j.janiuk at oracle.com>
Committer: Tobias Hartmann <thartmann at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/c3a7f2f4bce9170c1630e01eebd4fcd174b44964
Stats:     140 lines in 1 file changed: 24 ins; 29 del; 87 mod

8277382: make c1 BlockMerger use IR::verify only when necessary

Reviewed-by: thartmann, neliasso

-------------

PR: https://git.openjdk.java.net/jdk/pull/6456


More information about the hotspot-compiler-dev mailing list