RFR: 8277928: Fix compilation on macosx-aarch64 after 8276108

Thomas Schatzl tschatzl at openjdk.java.net
Mon Nov 29 11:40:23 UTC 2021


Hi all,

  can I have reviews for this change that uses a wrong format specifier for int64 which makes osx/aarch64 builds fail.

[2021-11-29T10:42:32,638Z] .../src/hotspot/cpu/aarch64/assembler_aarch64.hpp:482:41: error: format specifies type 'long' but the argument has type 'int64_t' (aka 'long long') [-Werror,-Wformat]
[2021-11-29T10:42:32,638Z]                "must be, was: %ld, %d", _offset, size);
[2021-11-29T10:42:32,638Z]                               ~~~       ^~~~~~~
[2021-11-29T10:42:32,638Z]                               %lld
[2021-11-29T10:42:32,638Z] .../debug.hpp:65:36: note: expanded from macro 'assert'```

Instead of the hardcoded `%ld` the change uses `INT64_FORMAT`.

Testing: tier1 running, Gha

Thanks,
  Thomas

-------------

Commit messages:
 - Fix format specifier

Changes: https://git.openjdk.java.net/jdk/pull/6590/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6590&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8277928
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/6590.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/6590/head:pull/6590

PR: https://git.openjdk.java.net/jdk/pull/6590


More information about the hotspot-compiler-dev mailing list