RFR: 8274730: AArch64: AES/GCM acceleration is broken by the fix for JDK-8273297
Vladimir Kozlov
kvn at openjdk.java.net
Tue Oct 5 16:14:11 UTC 2021
On Tue, 5 Oct 2021 09:58:38 GMT, Andrew Haley <aph at openjdk.org> wrote:
> The recent AES/GCM acceleration on AArch64 was broken by https://bugs.openjdk.java.net/browse/JDK-8273297 . This was entirely expected, and I approved the patch, but now we must make AArch64 acceleration work again.
> The only significant change from the point of view of this patch is that one argument was added to the call to the intrinsic, and that argument caused another argument to spill onto the stack.
Looks good with just 2 small comments.
I will test changes and approve it after that.
src/hotspot/share/opto/library_call.cpp line 6800:
> 6798: if (Matcher::htbl_entries == -1) return false;
> 6799:
> 6800: // new array to hold 48 computed htbl entries
Move this comment under `(Matcher::htbl_entries != 0)` check.
src/hotspot/share/opto/library_call.cpp line 6806:
> 6804: if (subkeyHtbl_48_entries == NULL) return false;
> 6805: subkeyHtbl_48_entries_start
> 6806: = array_element_address(subkeyHtbl_48_entries, intcon(0), T_LONG);
Please, don't split such line.
-------------
PR: https://git.openjdk.java.net/jdk/pull/5819
More information about the hotspot-compiler-dev
mailing list