RFR: 8274329: Fix non-portable HotSpot code in MethodMatcher::parse_method_pattern [v2]

Jie Fu jiefu at openjdk.java.net
Wed Oct 6 05:17:28 UTC 2021


On Wed, 6 Oct 2021 04:30:12 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> It's hard to tell what's the difference between these two RANGEBASE definitions. How about doing it like this to make the code more readable?
> 
> ```
> #define RANGEBASE_ASCII "....."
> #define RANGEBASE_NON_ASCII "....."
> #ifdef WINDOWS
> #define RANGEBASE RANGEBASE_ASCII
> #else  
> #define RANGEBASE RANGEBASE_ASCII RANGEBASE_NON_ASCII 
> #endif
> ```

Good suggestion!
Updated.
Thanks.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5704


More information about the hotspot-compiler-dev mailing list