RFR: 8273563: Improve performance of implicit exceptions with -XX:-OmitStackTraceInFastThrow [v3]

[Volker Simonis]

On Tue, 5 Oct 2021 15:35:57 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Volker Simonis has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
>> 
>>  - Fix special case where we're creating an implicit exception for a regular invoke* bytecode
>>  - Minor updates as requested by @TheRealMDoerr
>>  - 8273563: Improve performance of implicit exceptions with -XX:-OmitStackTraceInFastThrow
>
> Thanks for the update! New version looks good to me and our tests with disabled OmitStackTraceInFastThrow have passed. I think you should choose a couple of jtreg tests and add an additional run with OmitStackTraceInFastThrow disabled. What do you think?

Thanks for running the test @TheRealMDoerr. 

I've also run tier1/tier2/jck_runtime/jck_compiler on both linux/amd64 and linux/aarch64 with a special build where `OmitStackTraceInFastThrow` was disabled. I haven't seen any problems except for `compiler/loopopts/TestDivZeroCheckControl.java` which timeouts. But that's expected because that test creates `ArithmeticExceptions` in a hot loop. My change makes it run in half the time, but that's still not enough to prevent timeouts :)

Anything left before you can formally review the change?

-------------

PR: https://git.openjdk.java.net/jdk/pull/5488